Fix Annotation Position Lookup #141
Open
+30
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }).findFirst().map(CtElement::getPosition).orElse(element.getPosition()); | ||
| public static SourcePosition getAnnotationPosition(CtElement element, String refinement) { | ||
| return element.getAnnotations().stream() | ||
| .filter(a -> isLiquidJavaAnnotation(a) && hasRefinementValue(a, "\"" + refinement + "\"")).findFirst() |
Collaborator
There was a problem hiding this comment.
will this work well if the error is just on the "to" of a state refinement?
Collaborator
Author
There was a problem hiding this comment.
Yeah, It can be in either the value field of a @Refinement or in the from or to of a @StateRefinement. This logic is simply to get the position of the annotation that actually contains the refinement that caused error, e.g. we could have multiple state refinements and we want to get the position of the right one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small issue where if we had a syntax error in LiquidJava annotation other than
@Refinement, aNoSuchMethodExceptionwas thrown because when trying to get the source location of the annotation, I only considered@Refinementannotations. Also added a test case with a syntax error in a state refinement that previously would throw an exception.